Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework sampling trace counter names + new trace counters #30

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Rework sampling trace counter names + new trace counters #30

merged 2 commits into from
Jun 9, 2022

Conversation

jrmadsen
Copy link
Collaborator

@jrmadsen jrmadsen commented Jun 8, 2022

  • reformulate trace counter names for easier comparison
  • new process-level trace counters for context switches (thread sampling)
  • new process-level trace counters for page faults (thread sampling)
  • new process-level trace counters for CPU time (thread sampling)
  • new thread-level trace counters for context switches (sampling)
  • new thread-level trace counters for page faults (sampling)

@jrmadsen
Rework sampling trace counter names + new trace counters
7fa8489 
- reformulate trace counter names for easier comparison (thread sampling)
- new process-level trace counters for context switches (thread sampling)
- new process-level trace counters for page faults (thread sampling)
- new process-level trace counters for CPU time (thread sampling)
- new thread-level trace counters for context switches (sampling)
- new thread-level trace counters for page faults (sampling)
@jrmadsen
tweak header include in backtrace.cpp
aaa5fe2
@jrmadsen jrmadsen force-pushed the rework-perfetto-trace-counters branch from e5ebe74 to aaa5fe2 Compare June 9, 2022 16:25
@jrmadsen jrmadsen added enhancement New feature or request perfetto Issue affects/involves perfetto features/capabilities libomnitrace Involves omnitrace library sampling Statistical sampling via interrupts process sampling Background system-level sampling performed in background thread labels Jun 9, 2022
@jrmadsen jrmadsen requested a review from ratamima June 9, 2022 17:25
jrmadsen
jrmadsen commented Jun 9, 2022
View reviewed changes
Copy link
Collaborator Author

@jrmadsen jrmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me

ratamima
ratamima approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@ratamima ratamima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good.

@jrmadsen jrmadsen requested a review from ratamima June 9, 2022 18:24
ratamima
ratamima approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@ratamima ratamima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

@jrmadsen jrmadsen merged commit 1db3934 into ROCm:main Jun 9, 2022
@jrmadsen jrmadsen deleted the rework-perfetto-trace-counters branch June 9, 2022 18:43
@jrmadsen jrmadsen mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratamima ratamima ratamima approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request libomnitrace Involves omnitrace library perfetto Issue affects/involves perfetto features/capabilities process sampling Background system-level sampling performed in background thread sampling Statistical sampling via interrupts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reformulate TRACE_COUNTER names for readability
2 participants
@jrmadsen @ratamima