Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP API args in perfetto + new perfetto categories #76

Merged
merged 7 commits into from
Jun 29, 2022
Merged

HIP API args in perfetto + new perfetto categories #76

merged 7 commits into from
Jun 29, 2022

Conversation

jrmadsen
Copy link
Collaborator

  • Support for HIP API function args in perfetto
  • PERFETTO_CATEGORIES -> OMNITRACE_PERFETTO_CATEGORIES ppdef
  • Changed perfetto categories for several trace events and trace counters
  • migrated several TRACE_EVENT_* to use omnitrace::tracing::{push,pop}_perfetto_ts(...)
  • Tweaked category_region to encode the type of args as well as value
  • Improved testing in ubuntu-focal.yml
    • "Test Install" step sources setup-env.sh
    • "Test Install" step tests python support
    • "Test Install" step tests reading ~/.omnitrace.cfg
    • Avoid installing boost and tbb libs when building from submodule
  • validate-perfetto-proto.py accepts -m / --categories command line option for filtering out categories

HIP API Arguments

HIP API Arguments in Perfetto

MPI data types along with values

MPI data types along with values in Perfetto

@jrmadsen jrmadsen added enhancement New feature or request perfetto Issue affects/involves perfetto features/capabilities sampling Statistical sampling via interrupts process sampling Background system-level sampling performed in background thread roctracer GPU kernel tracing testing Extends/improves/modifies testing labels Jun 29, 2022
@jrmadsen
HIP API perfetto args + updated perfetto categories
0cafc9c 
- Support for HIP API args field in perfetto
- PERFETTO_CATEGORIES -> OMNITRACE_PERFETTO_CATEGORIES
- Changed perfetto categories for several trace events and trace counters
- migrated several TRACE_EVENT_* to use omnitrace::tracing::{push,pop}_perfetto_ts(...)
@jrmadsen
Tweaked category_region to encode the type of args as well as value
d1284a3 
- Affects MPI args field in perfetto
@jrmadsen
Improved testing in ubuntu-focal.yml
47c1837 
- "Test Install" step sources setup-env.sh
- "Test Install" step tests python support
- "Test Install" step tests reading ~/.omnitrace.cfg
- Avoid installing boost and tbb libs when building from submodule
@jrmadsen
validate-perfetto-proto.py accepts -m / --categories
e2200d1
@jrmadsen
Remove reference from category_region typeids
1f6529f
@jrmadsen jrmadsen force-pushed the hip-api-args-and-perfetto-categories branch from 4db8bb3 to 1f6529f Compare June 29, 2022 16:08
@jrmadsen jrmadsen changed the title Hip api args and perfetto categories HIP API args in perfetto + new perfetto categories Jun 29, 2022
@jrmadsen jrmadsen merged commit 2e1fd5a into ROCm:main Jun 29, 2022
@jrmadsen jrmadsen deleted the hip-api-args-and-perfetto-categories branch June 29, 2022 21:26
@jrmadsen jrmadsen added the libomnitrace Involves omnitrace library label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request libomnitrace Involves omnitrace library perfetto Issue affects/involves perfetto features/capabilities process sampling Background system-level sampling performed in background thread roctracer GPU kernel tracing sampling Statistical sampling via interrupts testing Extends/improves/modifies testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrmadsen