[release/2.5] [user triton] Ignore backend-specific args in the TTIR analysis (#141… #1768
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch#141062) Fixes pytorch#140800. On AMD, backend-specific args like `matrix_instr_nonkdim`, `waves_per_eu` and `kpack` are passed either direclty to the kernel or via `triton.Config`, whereas they don't exist as kernel parameters. Native Triton code handles those excessive args [here](https://github.com/triton-lang/triton/blob/a6bb57d6285e723c58e87dd7cba263db6efff789/python/triton/runtime/jit.py#L594-L596). In this PR, we add similar handling to the TTIR analysis code to avoid bailing out. Pull Request resolved: pytorch#141062 Approved by: https://github.com/oulgen (cherry picked from commit b740a1b)
|
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
|
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
|
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit is in progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pytorch#140800.
On AMD, backend-specific args like
matrix_instr_nonkdim,waves_per_euandkpackare passed either direclty to the kernel or viatriton.Config, whereas they don't exist as kernel parameters. Native Triton code handles those excessive args here. In this PR, we add similar handling to the TTIR analysis code to avoid bailing out. Pull Request resolved: pytorch#141062 Approved by: https://github.com/oulgen(cherry picked from commit b740a1b)
Fixes #ISSUE_NUMBER