Changes for multiple ROCm installation #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paulfreddy
commented
Jan 2, 2020
•
paulfreddy
commented
- Set soversion to match release version
1. Set version to 2.10.1 2. Add CMAKE_INSTALL_PREFIX to neccessary places 3. Cleanup, fix rpath, use prefix in install.sh
saadrahim
requested changes
Jan 2, 2020
1. Set soversion to match release version 2. Add CMAKE_INSTALL_PREFIX to neccessary places 3. Cleanup, fix rpath, use prefix in install.sh
gilbertlee-amd
requested changes
Jan 2, 2020
saadrahim
reviewed
Jan 3, 2020
1. Set soversion to match release version 2. Add CMAKE_INSTALL_PREFIX to neccessary places 3. Cleanup, fix rpath, use prefix in install.sh
|
Any more comments on this PR. Hope this is OK to be merged. |
saadrahim
approved these changes
Jan 8, 2020
gilbertlee-amd
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.