Fix Docs static analysis #708

samjwu · 2023-03-16T15:31:31Z

Removes references to old doc scripts replaced by rocm-docs-core which were causing Jenkins static analysis job to fail (90a2113)

Also update README with new instructions for building docs and .gitignore with doc artifacts (b021aea)

Read the Docs build: https://readthedocs.com/projects/advanced-micro-devices-rccl/builds/1356055/

update gitignore with doc artifacts

gilbertlee-amd · 2023-03-16T15:40:05Z

.jenkins/staticanalysis.groovy

@@ -12,28 +12,6 @@ import java.nio.file.Path
 def runCompileCommand(platform, project, jobName, boolean debug=false)
 {
    project.paths.construct_build_prefix()


What does this function do now then?

This appears to be used for setting project_build_prefix, which is used as a path by other steps (eg: packaging)

* remove ref to old script in static analysis * update README with doc build instructions update gitignore with doc artifacts

Standard template implementation (#703) Fix Docs static analysis (#708) * remove ref to old script in static analysis * update README with doc build instructions update gitignore with doc artifacts pin rocm-docs-core and add dependabot config (#722) Bump rocm-docs-core from 0.2.0 to 0.5.0 in /docs/.sphinx (#728) Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.2.0 to 0.5.0. - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases) - [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](https://github.com/RadeonOpenCompute/rocm-docs-core/commits/v0.5.0) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Update Read the Docs, documentation, and dependabot (#772) * update documentation add version number to documentation rename .sphinx/.doxygen to sphinx/doxygen enable htmlzip, pdf, epub formats when publishing on Read the Docs * add noCI label for dependabot PRs since RTD CI is separate from math lib CI * update rocm-docs-core to v0.13.4 * update README with link to rocm.docs.amd.com

samjwu added 2 commits March 16, 2023 09:18

remove ref to old script in static analysis

90a2113

update README with doc build instructions

b021aea

update gitignore with doc artifacts

samjwu requested review from cgmb, saadrahim, stanleytsang-amd, gilbertlee-amd and eidenyoshida March 16, 2023 15:31

samjwu self-assigned this Mar 16, 2023

gilbertlee-amd reviewed Mar 16, 2023

View reviewed changes

gilbertlee-amd approved these changes Mar 16, 2023

View reviewed changes

samjwu merged commit 8c56e6c into ROCm:develop Mar 16, 2023

samjwu deleted the docs-static-analysis branch March 16, 2023 19:12

samjwu added a commit that referenced this pull request Jun 12, 2023

Fix Docs static analysis (#708)

bce9b17

* remove ref to old script in static analysis * update README with doc build instructions update gitignore with doc artifacts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Docs static analysis #708

Fix Docs static analysis #708

samjwu commented Mar 16, 2023 •

edited

Loading

gilbertlee-amd Mar 16, 2023

samjwu Mar 16, 2023 •

edited

Loading

Fix Docs static analysis #708

Fix Docs static analysis #708

Conversation

samjwu commented Mar 16, 2023 • edited Loading

gilbertlee-amd Mar 16, 2023

Choose a reason for hiding this comment

samjwu Mar 16, 2023 • edited Loading

Choose a reason for hiding this comment

samjwu commented Mar 16, 2023 •

edited

Loading

samjwu Mar 16, 2023 •

edited

Loading