Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive cholesky #710

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

EdDAzevedo
Copy link
Contributor

Implement recursive formulation of Cholesky factorization for n by n symmetric positive definite matrix A.

Let the following be a block partitioning of matrix A.

Here submatrix L22 is n/2 by n/2, L11 is n1 by n1, where n1 = n - n/2, or partition matrix at mid-point

[L11 0 ] * [ L11' L21'] = [A11 A21' ]
[L21 L22] [ L22'] [A21 A22 ]

(1) L11 * L11' = A11 , recursive Cholesky factorization

(2) L21 * L11' = A21 or
L21 = A21 / L11' triangular solve (TRSM)

(3) L21 * L21' + L22 * L22' = A22
or
(3a) A22 <- A22 - L21 * L21', symmetric rank-k update (SYRK)
(3b) L22 * L22' = A22, recursive Cholesky factorization

Note C++ recursion is performed on CPU host and the recursion depth is O( log2( n ) ).

@tfalders tfalders added the noOptimizations Disable optimized kernels for small sizes for some routines label May 27, 2024
@tfalders
Copy link
Collaborator

I have opened a PR on your local fork with my suggested changes. Please have a look when you have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
noOptimizations Disable optimized kernels for small sizes for some routines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants