find_package (ROCM is confusing #49
Comments
|
@pfultz2 Can you weigh in on this? Using the name |
lawruble13
added a commit
that referenced
this issue
Oct 11, 2023
Having the name of this CMake package be ROCM is consistently confusing to users who expect find_package(ROCM [...]) to add ROCm packages to their build, instead of tools that we use to build ROCm (see #49). Renaming the CMake project to ROCmCMakeBuildTools makes the purpose of this package clearer. In order to have as smooth a transition as possible, starting this as a notice, will make into a deprecation/warning in ~6.2, error sometime later, remove in 7.0.
lawruble13
added a commit
that referenced
this issue
Oct 11, 2023
Having the name of this CMake package be ROCM is consistently confusing to users who expect find_package(ROCM [...]) to add ROCm packages to their build, instead of tools that we use to build ROCm (see #49). Renaming the CMake project to ROCmCMakeBuildTools makes the purpose of this package clearer. In order to have as smooth a transition as possible, starting this as a notice, will make into a deprecation/warning in ~6.2, error sometime later, remove in 7.0.
lawruble13
added a commit
that referenced
this issue
Oct 11, 2023
For discussion, see: Rename CMake package to ROCmCMakeBuildTools (#128). Having the name of this CMake package be ROCM is consistently confusing to users who expect find_package(ROCM [...]) to add ROCm packages to their build, instead of tools that we use to build ROCm (see #49). Renaming the CMake project to ROCmCMakeBuildTools makes the purpose of this package clearer. In order to have as smooth a transition as possible, starting this as a notice, will make into a deprecation/warning in ~6.2, error sometime later, remove in 7.0.
lawruble13
added a commit
to lawruble13/rocm-cmake
that referenced
this issue
Oct 11, 2023
For discussion, see: Rename CMake package to ROCmCMakeBuildTools (ROCm#128). Having the name of this CMake package be ROCM is consistently confusing to users who expect find_package(ROCM [...]) to add ROCm packages to their build, instead of tools that we use to build ROCm (see ROCm#49). Renaming the CMake project to ROCmCMakeBuildTools makes the purpose of this package clearer. In order to have as smooth a transition as possible, starting this as a notice, will make into a deprecation/warning in ~6.2, error sometime later, remove in 7.0.
lawruble13
added a commit
that referenced
this issue
Oct 11, 2023
For discussion, see: Rename CMake package to ROCmCMakeBuildTools (#128). Having the name of this CMake package be ROCM is consistently confusing to users who expect find_package(ROCM [...]) to add ROCm packages to their build, instead of tools that we use to build ROCm (see #49). Renaming the CMake project to ROCmCMakeBuildTools makes the purpose of this package clearer. In order to have as smooth a transition as possible, starting this as a notice, will make into a deprecation/warning in ~6.2, error sometime later, remove in 7.0.
|
Hi @saadrahim, is there any further work required for this ticket? Can I close it? Thanks. |
|
It is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Invoking
find_package( ROCM 0.5 CONFIG QUIET PATHS ${ROCM_PATH} /opt/rocm )
to include rocm-cmake is confusing.
We should consider changing the name to ROCM-CMAKE.
The text was updated successfully, but these errors were encountered: