-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version number and changelog for ROCm 6.1 (#169) #209
Conversation
CMakeLists.txt
Outdated
@@ -20,7 +20,7 @@ list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR}/share/rocmcmakebuildtool | |||
include(ROCMCreatePackage) | |||
include(ROCMSetupVersion) | |||
|
|||
rocm_setup_version(VERSION 0.11.0) | |||
rocm_setup_version(VERSION 0.12.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 0.13.0? That's what the changelog says.
The version is 0.12.0 in the 6.1 release branch https://github.com/ROCm/rocm-cmake/blob/release-staging/rocm-rel-6.1/CMakeLists.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created #210 to address this. will cherry pick that change into this PR if it is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Root cause was that I couldn't merge #171 until after branching due to test failures... or, at least, one of the root causes. |
* Update version in CMakeLists.txt to match changelog * Fix markdownlint formatting in changelog
No description provided.