forked from tensorflow/tensorflow
-
Notifications
You must be signed in to change notification settings - Fork 94
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Migrate TFs third_party/gpus/crosstool to Starlark
This cl makes this toolchain forward compatible for Bazel's incompatible flags: * bazelbuild/bazel#7008 * bazelbuild/bazel#6861 * bazelbuild/bazel#7320 The current change creates a drop-in replacement for the proto crosstool, with the exception that: * all legacy fields are removed * templated variables are replaced by rule attributes * instead of empty paths in msvc toolchain we now use 'msvc_not_used' path (CcToolchainConfigInfo doesn't allow empty strings for paths). * introduced to_list_of_strings function so we can pass list of starlark string around The mechanical transformation makes the crosstool definition less readable than before - this will be addressed in a subsequent change. This change was tested by: 1) running cuda_configure.bzl and retrieving generated BUILD and CROSSTOOL files 2) applying this change 3) running cuda_configure.bzl and retrieving generated BUILD and cc_toolchain_config.bzl files 4) Using [cc_toolchain_compare_test](https://github.com/bazelbuild/rules_cc/blob/master/tools/migration/ctoolchain_compare.bzl#L24) rule to verify both CROSSTOOL and cc_toolchain_configs configure the C++ toolchain identically PiperOrigin-RevId: 248094053
- Loading branch information
1 parent
650d849
commit 1362c14
Showing
8 changed files
with
1,742 additions
and
1,679 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.