Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inclusion of data extractor for current/voltage/temperature vs time d… #11

Merged
merged 3 commits into from
Dec 20, 2022
Merged

inclusion of data extractor for current/voltage/temperature vs time d… #11

merged 3 commits into from
Dec 20, 2022

Conversation

npaulson
Copy link
Contributor

inclusion of data extractor for current/voltage/temperature vs time data, and example processing script for open lead-acid battery cycling dataset. Corrections to postprocessing codes for extracting capacity and energy versus cycling

inclusion of data extractor for current/voltage/temperature vs time d…
23e3c40 
…ata, and example processing script for open lead-acid battery cycling dataset. Corrections to postprocessing codes for extracting capacity and energy versus cycling
WardLT
WardLT requested changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@WardLT WardLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes. Thanks, @npaulson !

batdata/extractors/tIVT.py Outdated Show resolved Hide resolved
batdata/extractors/tIVT.py Outdated Show resolved Hide resolved
scripts/howey.py Show resolved Hide resolved
WardLT added a commit that referenced this pull request Nov 21, 2022
@WardLT
Change how we index arrays
86927aa 
.at should be .loc (thanks @npaulson for fixing this in #11, I'm doing
it here to unblock myself with other work while your PR is in review)
WardLT added a commit that referenced this pull request Nov 22, 2022
@WardLT
Fix the MACCOR parser (#12)
e11e3e9 
* Create a test that will fail for MACCOR

* Change how we index arrays

.at should be .loc (thanks @npaulson for fixing this in #11, I'm doing
it here to unblock myself with other work while your PR is in review)

* Avoid setting values of copies

* Only run tests in the batdata directory
@WardLT WardLT merged commit 48eeb51 into ROVI-org:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WardLT WardLT WardLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npaulson @WardLT