@co012/position and bounds #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er extends GameObject
mhawryluk
approved these changes
May 14, 2022
Comment on lines
140
to
143
| private Point2D getBoundPosition(Point2D pos) { | ||
| double x = Math.max(0, Math.min(bounds.getX(), pos.getX())); | ||
| double y = Math.max(0, Math.min(bounds.getY(), pos.getY())); | ||
| return new Point2D(x, y); |
There was a problem hiding this comment.
The behavior of bounds is inconsistent - top and left bounds stop the player immediately, while the right and bottom ones let them cross up to half of the player's size.
I think there are two equally good options from here:
- change from 0 to -0.5 in Math.max
or: - change bounds from (9.5, 9.5) to (9, 9), or in general when read from config: (width-1, height-1)
There was a problem hiding this comment.
You, are right. I'll go with your first suggestion
| import java.lang.reflect.Field; | ||
| import java.util.LinkedHashSet; | ||
| import java.util.Optional; | ||
| import java.util.Set; | ||
| import javafx.beans.property.ObjectProperty; |
Co-authored-by: Marcin Hawryluk <70582973+mhawryluk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist