Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: asset path resolution #91

Merged
merged 3 commits into from
Jun 7, 2022
Merged

fix: asset path resolution #91

merged 3 commits into from
Jun 7, 2022

Conversation

kkafar
Copy link
Collaborator

@kkafar kkafar commented Jun 7, 2022

Description

Right now in every root.json file asset-dir path must be specified. See the docs for more specifics.

Checklist

  • Included code to test these changes
  • Updated Jira

@kkafar kkafar requested review from mhawryluk, co012, ksiek127, Monatyr and zamojtel and removed request for mhawryluk June 7, 2022 10:13
Monatyr
Monatyr approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@Monatyr Monatyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kkafar kkafar merged commit 935fc29 into master Jun 7, 2022
@kkafar kkafar deleted the @kkafar/fix-paths branch June 7, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monatyr Monatyr Monatyr approved these changes

@co012 co012 Awaiting requested review from co012

@ksiek127 ksiek127 Awaiting requested review from ksiek127

@zamojtel zamojtel Awaiting requested review from zamojtel

@mhawryluk mhawryluk Awaiting requested review from mhawryluk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkafar @Monatyr