Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ConnectionInfoDialog does not show the active interface #4206

Closed
PeterPeet opened this issue Jul 14, 2023 · 1 comment · Fixed by #4208
Closed

[Bug]: ConnectionInfoDialog does not show the active interface #4206

PeterPeet opened this issue Jul 14, 2023 · 1 comment · Fixed by #4208
Assignees
Labels

Comments

@PeterPeet
Copy link

PeterPeet commented Jul 14, 2023

Describe the Bug

If there are more then one networkinterface on the local machine, the ConnectionInfoDialog does not show the active interface, but the last one.

To Reproduce

Goto serverinformation while having more then one ethernet interface while the first interface is active.

Expected Behaviour

You will get the local address of the last interface.

Screenshots

No response

MapTool Info

1.13.2

Desktop

Windows10

Additional Context

No response

@PeterPeet PeterPeet added the bug label Jul 14, 2023
PeterPeet pushed a commit to PeterPeet/maptool that referenced this issue Jul 14, 2023
github-merge-queue bot pushed a commit that referenced this issue Jul 25, 2023
#4207 #4206 Changed the ConnectionInfoDialog to show active interface…
@kwvanderlinde
Copy link
Collaborator

Tested this by bringing different combinations of interfaces up or down.

It appears to be working. If I get one IP address from an interface, then bring that interface down and restart MapTool, I get a different address. Complete verification is hampered by the bug I mentioned in the sister issue, but things appear to be in order for this issue.

An edge case is what happens with all interfaces down. In that case no local address is displayed, not even a loopback, while on 1.13.2 and earlier a loopback would be shown. I wonder if we should still allow lookbacks to be shown in this case? It's certainly very niche, though there are folks who run multiple MT instances on a single PC and may be still benefit from being shown a lookback address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Testing
Development

Successfully merging a pull request may close this issue.

2 participants