Merge Dicelib code into MapTool Repo #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix build and add keep lowest/drop highest dice rolls
New roll type support
new rolls and support for listing rolled dice
changed location that rolls are recorded
…ew value or choosing the higher of the two.
…tion to return a sequence of pre-configured roll values for use in testing dice expressions. Providing some expression tests that use the new RunDataMockForTesting to verify dice expression behavior against specific known roll sequences.
…Testing and specified sequence of die rolls. RPTools/dicelib#27
Add additional RerollOnce tests and apply formatting
ShadowRun 5 Dice Roll
…s using RunData to avoid a mock object being left as Current for tests not expecting it. RPTools/dicelib#82
Inform parent RunData when child makes a roll
Added function "rollSubWithUpper". Ordered existing functions: Upper/Lower, Add Upper/Lower, Sub Upper/Lower
Added regex for XdYaZlW for the existing function rollAddWithLower. Added regex for XdYsZuW for the newly submitted function rollSubWithUpper.
The function seems to have been introduced specifically for a substraction, but is now used for both addition and substraction. The variable is already named "mod" in the file "RollWithBounds.java", so I'm matching the name here.
Forgot to declare the name. Please confirm this one in particular, because I only have a vague understanding of what "3, 4" does for super() here.
Most of the other functions have a data conversion here, so I included the same. I checked dicelib and maptool for usages of "RollWithBounds" and looked for the six different function names. I didn't find any conflict with the int to BigDecimal change. Spaces due to auto-formatting.
Merge 1.7.1 to main.
|
Isn't this the perfect time to use move the current code into a subdir and use a proper multiproject configuration in the repository? I think I have done this locally in a branch I could check and prepare a PR. |
As already discussed before, what benefit would this buy us that out weighs the extra complexity, (especially for those new to GIT). No benefits were given last time it was discussed, so I have no inclination to do it just for the sake of doing it. |
kwvanderlinde
approved these changes
Apr 25, 2023
cwisniew
added
the
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
resolves #3999
Description of the Change
The source for Dicelib has been merged into the MapTool Repo (preserving history as I don't want to steal anyones thunder).
Possible Drawbacks
Little longer to build, but shouldn't be much longer
Release Notes
This change is