Fill the lumens overlay properly #4045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using SrcOver would combine the overlay with the existing contents of the buffer. Now that the buffer is not cleared beforehand, this problem has become visible. FIXUP
cwisniew
approved these changes
May 9, 2023
|
@kwvanderlinde, just to make sure before I merge, is this intended for 1.13.1 or 1.14 |
|
1.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes a missed case in PR #4003.
Description of the Change
We removed the logic to clear images returned from
BufferedImagePoolbecause all the uses of it already either cleared the image or rendered to it completely.While the lumens overlay also filled the buffer before rendering, it mistakenly did that with
SrcOver, meaning the existing contents of the buffer were being mixed with the fill color. This has now been changed so that it instead usesSrcto overwrite the buffer contents.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
N/A (only exists in develop)
This change is