Fix for error when executing a token macro as a player with the current map not visible #4101
Conversation
cwisniew
changed the title
There was a problem hiding this comment.
Thanks for the pull request; it will need a little change to work correctly.
Also, it would be appreciated if you could fill out the details in the PR as that is what gets added to the release notes by github, if there is no real information about the fix in the title and the PR body it will be harder for people to find what was fixed.
| AllTokenIDs.add(token.getId()); | ||
| } | ||
| renderer.getSelectionModel().removeTokensFromSelection(AllTokenIDs); | ||
| MapTool.getFrame().setCurrentZoneRenderer(null); |
There was a problem hiding this comment.
The changes you made should be in the below if statement (where it is setting the current zone renderer to null) because, at the moment, it will get executed for players and GMs when any map is made invisible or visible.
You can also simplify it as
var selected = List.copyOf(renderer.getZone().getAllTokens());
render.getSelectionModel().removeTokensFromSelection(selected);
There was a problem hiding this comment.
Hi, i have updated the commit to put the code below the if statement, now its working.
Identify the Bug or Feature request
Fixes #4100
Description of the Change
When executing a token macro as a player with the current map not visible it will return that error:
Thats because in the execution of Token macros a lot of thing needs the current zone(that is null when the map is not visible)
Possible Drawbacks
None expected
Documentation Notes
Fix for error when executing a token macro as a player with the current map is not visible
Release Notes
This change is