Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display name to token properties #4235

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Aug 3, 2023

Identify the Bug or Feature request

resolves #4234

Description of the Change

Adds Display Name to Property definitions
CleanShot 2023-08-03 at 23 46 14@2x

Adds the macro function
getPropertyDisplayName(propertyType, propertyName)
e.g. getPropertyDisplayName("Basic", "Strength")

The display name is passed to stat sheet as displayName, the property name as name, but generally, display name should always be used
CleanShot 2023-08-03 at 23 47 37@2x

Possible Drawbacks

Should be none

Documentation Notes

Add display name to properties which is usable in new stat sheets and macros.

Release Notes

  • Add display name to properties which is usable in new stat sheets and macros.

This change is Reviewable

@cwisniew cwisniew added the feature Adding functionality that adds value label Aug 3, 2023
@cwisniew cwisniew added this pull request to the merge queue Aug 14, 2023
Merged via the queue into RPTools:develop with commit 2e20a87 Aug 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Feature]: Add a display name for token properties
2 participants