Fix table import/export buttons with classic icons. #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous empty string was being interpreted as a real path pointing to the resource directory. Using `null` makes it clear that it is not a path, and the resource manager already easily handles that case.
cwisniew
approved these changes
Aug 30, 2023
kwvanderlinde
deleted the
bugfix/4268-fix-error-on-missing-classic-icons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4268
Description of the Change
Deliberately missing icons are now marked with a
nullvalue rather than an empty string.nullis less likely to be interpreted as a real path (as""was), and makes this case closer to the case where an icon set does not include an icon key at all. A slight tweak toRessourceManager.getFromHashMapsAndCache()makes the the two cases exactly equivalent.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is