Go back to enumerating HTML5 child nodes when added, and adding event listeners to them #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML5 event listeners are now registered as before. However, to avoid peering issues in JavaFX <22, new listeners are created each time the page is unloaded.
kwvanderlinde
force-pushed
the
bugfix/4048-now-there-are-missing-events
branch
from
1bb31e9
to
776e07d
Compare
|
I'll move this off the |
1.14 is good :) |
cwisniew
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Improves #4048
Description of the Change
This basically reverts PRs #4259 and #4285, though with the one difference that our event listener objects are recreated each time the page is unloaded. By keeping the same listeners for the duration of the page, we avoid the redundant registration that motived PR #4285. By recreating the listeners when leaving or switching pages, we avoid the peering issue that motivated #4259.
Possible Drawbacks
I break some else's framework in some other unknown way.
Documentation Notes
N/A
Release Notes
This change is