New function createAsset #4923
Merged
New function createAsset #4923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://discord.com/channels/296230822262865920/296658523725496320/578194944871759909 rest functions use macro.return instead of ParserException.
|
This needs to ensure the asset is valid before adding it to the campaign |
|
I do check file headers for the 3 file formats this function supports. If there are other checks I can do or add, I will try to comply with those. |
cwisniew
requested changes
Oct 10, 2024
src/main/java/net/rptools/maptool/client/functions/TokenImage.java
Outdated
Show resolved
Hide resolved
Added request changes to use constants Changed empty variable check Added NPE check for bad bytes
spotless proper
…velop_createAsset # Conflicts: # src/main/java/net/rptools/maptool/client/functions/TokenImage.java
spotless I hate thee
…velop_createAsset
cwisniew
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
https://discord.com/channels/296230822262865920/296658523725496320/578194944871759909
New trusted macro function
createAsset(name,imageData)that will return anasset:\\< asset ID >value on success.Checks are made for data types and only
webp,jpg,pngare permitted data types.Possible Drawbacks
createAssetcan allow scriptable asset creation and if implemented improperly, could be campaign breaking.With great power comes great responsibility.
Release Notes
Examples:
[r: createAsset("Test", < base64 encoded image data >)][r: createAsset("Test", "https://website.com/image.webp")]outputs
asset:\\< asset ID >(I renamed my branch as I almost overwrote it)
This change is