Fix hex light construction #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proportions and center were just all wrong. `Grid.getShapedArea()` should always treat (0, 0) as its origin for the light, so no adjustments are needed to account for the grid or token shape. Also fixed a bug where the hex radius would measure to the vertices instead of the edges (compare with square lights that measure to the edges). Since we're modifying the hex code anyways, also refactored to be more direct. We don't need trig - there's only six points and they're always the same up to scale. Well, until the day we account for stretched hex grids.
cwisniew
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4978
Description of the Change
For some reason hexes had an adjustment applied based on the token footprint. But light shapes should always use
(0, 0)as the origin, since other code will translate that to the necessary point. This PR removes that adjustment.The other issue regarding hex size was fixed by treating the range as an inradius instead of circumradius.
Also included is a refactoring to
Grid.createHex(). Nothing used the rotation parameter, and without that all hexes look the same aside from scale. So I removed the trig and loop and replaced it with six explicit points.Possible Drawbacks
Slightly different areas will be illuminated by hex lights with this change.
Documentation Notes
For hex lights, the range measures to the edge of the hex.
Release Notes
This change is