Github Action MacOSX revamp #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmiles
force-pushed
the
master-upstream-20231010-macosx
branch
from
d0e97e7
to
b09e8d3
Compare
|
Updated: Somehow lost TMPFILE=value assignment in YML during final prepare |
Example build issue using MacOS 12 (Xcode 14.2 from MacOSX.platform).
In file included from grTk1.c:23:
In file included from ../utils/main.h:26:
In file included from ../windows/windows.h:26:
../utils/magic.h:143:13: warning: 'FREAD' macro redefined [-Wmacro-redefined]
#define FREAD(a,b,c,d) gzread(d,a,b*c)
^
/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/fcntl.h:110:9: note: previous definition is here
#define FREAD 0x00000001
The -L option needs to be placed before the -l it needs to affect. This maybe important on MacOSX where a nonstandard/optional package provides X11 support so the locations are not in system locations.
dlmiles
force-pushed
the
master-upstream-20231010-macosx
branch
from
b09e8d3
to
360a158
Compare
|
Next iteration on MacOS CI in Github Acton:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FREAD macro name is renamed due to clash with sys/fcntl.h in Xcode SDK on MacOSX.
The GHA will build for both legacy x86_64 and newer ARM64 platforms.
The configure_mac resolves an issue with the wrong X/Xlib.h header being included due to a (bad) copy being bundled with tk-tcl when the copy from quartz is the one needed.