Remove some cells from no_synth.tcl and drc_excluded.tcl #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent updates to Openlane to use abc to map muxes (vs manual tech mapping), we can now use the inverting output 2 input mux cells.
The list of drc excluded cells was created almost a year ago, and lots of bugs in the tools have since been fixed (including issues with the drt pin access code).
|
I can't merge this---It needs to be taken up with the Openlane developers. If you can get their okay on it, I can merge it. |
|
@RTimothyEdwards makes sense. @donn any thoughts here? |
|
Hmm, I don't know. I'd have to run the extended test set on this. It's entirely possible something is still broken somewhere and/or we missed something. |
|
Here's at least one of the reasons we excluded a cell (a magic issue since fixed): |
|
I am finding some designs are struggling to route with this patch, investigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.