Fix LEF views of EF cells
#414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correctly set the `CLASS` property to `CLASS CORE SPACER` instead of `CLASS BLOCK` * Set missing `SYMMETRY` property to `X Y R90` to match `fd_sc_hd` fill cells * Set missing `SITE` property to `unithd` * Created missing `sky130_ef_sc_hd__fill_4.v` * Remove `fakediode`: Maintaining it is no longer worth it
RTimothyEdwards
approved these changes
Nov 2, 2023
|
Pulled and merged to opencircuitdesign.com. |
RTimothyEdwards
added a commit
that referenced
this pull request
Nov 3, 2023
from Donn (fixes the custom LEF views of the EF cells in the HD standard cell library, and deprecates the "fakediode" cell).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLASSproperty toCLASS CORE SPACERinstead ofCLASS BLOCKSYMMETRYproperty toX Y R90to matchfd_sc_hdfill cellsSITEproperty tounithdsky130_ef_sc_hd__fill_4.vfakediode: Maintaining it is no longer worth itResolves (1) of #413