Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sky130A OpenLane KLayout DRC support #418

Closed
wants to merge 3 commits into from

Conversation

kareefardi
Copy link
Contributor

@kareefardi kareefardi commented Nov 22, 2023

This is a Draft PR. Don't merge yet.
Edit:
This is good for review and merge now.

Edit 2:

+ Add KLAYOUT_DRC_OPTIONS for integration with OpenLane
~ Rename KLAYOUT_DRC_TECH_SCRIPT to KLAYOUT_DRC_RUNSET to be consistent with terminology found in KLayout documentation.

@kareefardi
Copy link
Contributor Author

@marwaneltoukhy @donn Please review

@marwaneltoukhy
Copy link
Collaborator

LGTM

@kareefardi kareefardi marked this pull request as ready for review November 28, 2023 17:03
@RTimothyEdwards
Copy link
Owner

@kareefardi @marwaneltoukhy @donn : How does this change make any sense? It's not just renaming KLAYOUT_DRC_TECH_SCRIPT to KLAYOUT_DRC_RUNSET, but it's doing it only for sky130A, and leaving it undefined for sky130B.

@kareefardi
Copy link
Contributor Author

kareefardi commented Nov 29, 2023

@RTimothyEdwards as far as I know we don't have a KLayout DRC deck for sky130B.
And in OpenLane we can make optional PDK variables that may or may not be defined by the PDK.

@kareefardi kareefardi changed the title add KLAYOUT_DRC_OPTIONS for integration with OpenLane Sky130A OpenLane KLayout DRC support Nov 29, 2023
@RTimothyEdwards
Copy link
Owner

@kareefardi : If you ran the existing klayout DRC deck on a sky130B design, then you would simply miss rules regarding ReRAM but catch everything else. So instead, you would rather not run it at all and fail to provide any DRC results back to the user, instead of providing them with 99.5% of the checks?

@kareefardi
Copy link
Contributor Author

@RTimothyEdwards Ok make sense. Thank you. I removed the if condition allowing only sky130A

Copy link
Owner

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looks good now.

@RTimothyEdwards
Copy link
Owner

Pulled and merged on opencircuitdesign.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants