-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sky130A OpenLane KLayout DRC support #418
Conversation
default disable floating_metal
@marwaneltoukhy @donn Please review |
LGTM |
@kareefardi @marwaneltoukhy @donn : How does this change make any sense? It's not just renaming KLAYOUT_DRC_TECH_SCRIPT to KLAYOUT_DRC_RUNSET, but it's doing it only for sky130A, and leaving it undefined for sky130B. |
@RTimothyEdwards as far as I know we don't have a KLayout DRC deck for sky130B. |
@kareefardi : If you ran the existing klayout DRC deck on a sky130B design, then you would simply miss rules regarding ReRAM but catch everything else. So instead, you would rather not run it at all and fail to provide any DRC results back to the user, instead of providing them with 99.5% of the checks? |
@RTimothyEdwards Ok make sense. Thank you. I removed the if condition allowing only sky130A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, looks good now.
Pulled and merged on opencircuitdesign.com. |
This is a Draft PR. Don't merge yet.Edit:
This is good for review and merge now.
Edit 2:
+ Add KLAYOUT_DRC_OPTIONS for integration with OpenLane
~ Rename
KLAYOUT_DRC_TECH_SCRIPT
toKLAYOUT_DRC_RUNSET
to be consistent with terminology found in KLayout documentation.