Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download.sh #420

Closed
wants to merge 1 commit into from
Closed

Fix download.sh #420

wants to merge 1 commit into from

Conversation

donn
Copy link
Contributor

@donn donn commented Nov 30, 2023

  • Renamed GIT to git_retry (more descriptive)
  • Made git_retry return an error code instead of exiting unilaterally
  • Removed git_retry from git clone -- branch -- it already has a fallback on failure
  • Removed git_retry from checkout command (offline)
  • misc: Fixed indentation of gf180mcu/gf180mcu.json

* Renamed `GIT` to `git_retry` (more descriptive)
* Made `git_retry` return an error code instead of exiting unilaterally
* Removed `git_retry` from `git clone -- branch` -- it already has a fallback on failure
* Removed `git_retry` from `checkout` command (offline)
* misc: Fixed indentation of `gf180mcu/gf180mcu.json`
Copy link
Owner

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@RTimothyEdwards
Copy link
Owner

Pulled and merged in opencircuitdesign.com.

RTimothyEdwards added a commit that referenced this pull request Dec 3, 2023
from Donn (fixes minor issues in the recently-modified "download.sh"
script).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants