Update datetimepicker component to v4.17.47 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datetimepicker autocomplete was failing if you added `moment-timezone-with-data` to donkeykong's application.js file. It would clear the field if you enter a date (e.g., 10/11) and press enter, it it supposed to parse that date and update the field with the full date. This problem appears to be resolved by updating to the latest version of datetimepicker, not sure why it was broken but if this fixes it then that's good enough for me.
csexton
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
datetimepickerautocomplete was failing if you addedmoment-timezone-with-datato donkeykong's application.js file. It would clear the field if you enter a date (e.g., 10/11) and press enter, it it supposed to parse that date and update the field with the full date.This problem appears to be resolved by updating to the latest version of
datetimepicker, not sure why it was broken but if this fixes it then that's good enough for me.To do the update I just downloaded the latest release from github and dropped it into
app/assets/components