Add topnavbar to theme assets #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted the topnavbar to erb and added the partial. This allow us to easily update the top navigation across any site that uses the radius theme and have it be consistent. The instigator here was removing the link to the plans page. Ya know, since there is no more plans page. I added helpers for building the urls, most of them check to see if the equivalent route is defined and return that if so. These should only be defined in the Kracken Rails app itself, so the links in that dropdown will use the local app. This works great for most links. The `destroy_user_session_path` is only defined in Kracken Rails, so can check if that exists; if it does use it, else build the url from the `kracken_url`. It doesn't work for `teams_path`, many of the client apps have a team controller so checking for that won't work well. Finding a way to detect if we are in the Kracken Rails app proved to be tricky and out of the scope of this change.
cupakromer
suggested changes
Jun 4, 2018
app/views/radius/_topnavbar.html.erb
Outdated
| <nav class="navbar topnavbar" role="navigation"> | ||
| <!--START navbar header--> | ||
| <div class="navbar-header"> | ||
| <a class="navbar-brand" href="//www.radiusnetworks.com/"> |
There was a problem hiding this comment.
Any reason to not hardcode this to HTTPS?
app/views/radius/_topnavbar.html.erb
Outdated
| </a> | ||
| </li> | ||
| <li> | ||
| <a href="//store.radiusnetworks.com" title="Radius Networks Store"> |
There was a problem hiding this comment.
Same comment here about forcing HTTPS
app/views/radius/_topnavbar.html.erb
Outdated
| <p class="m0">Teams</p> | ||
| <p class="m0 text-muted"> | ||
| <small> | ||
| You belong to <%= pluralize(current_user.accounts.count ,"team") %> |
There was a problem hiding this comment.
This will have problems on new apps as they do not have Account any more. Just teams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the topnavbar to erb and added the partial.
This allow us to easily update the top navigation across any site that uses the radius theme and have it be consistent. The instigator here was removing the link to the plans page. Ya know, since there is no more plans page.
I added helpers for building the urls, most of them check to see if the equivalent route is defined and return that if so. These should only be defined in the Kracken Rails app itself, so the links in that dropdown will use the local app.
This works great for most links. The
destroy_user_session_pathis only defined in Kracken Rails, so can check if that exists; if it does use it, else build the url from thekracken_url. It doesn't work forteams_path, many of the client apps have a team controller so checking for that won't work well.Finding a way to detect if we are in the Kracken Rails app proved to be tricky and out of the scope of this change. I am open to suggestions if you got 'em!