-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply our gentler color theming to Alert stylings #22
Conversation
Ref: RadiusNetworks/iris#3167 The colors were originally defined in Iris overrides, but those colors were only being applied to flash hashes. Error blocks and other bits here and there would have the original themed alerts come through, and these colors are more saturated and a bit "harsher". The original colors have been preserved in case they are used elsewhere, but the alerts themselves have been re-skinned to use the new color variables, which have been named in alignment with flashhash keys.
ca6c572
to
1b97523
Compare
I updated the gem version (patch bump) -- I don't need to build this gem or anything, right? We're just referencing it on the GH? |
From the bundler docs it looks like that is the case. Bundler should see there's a new version and get latest code. |
@armahillo From the issue, were we wanting to name the color groups more generically? If we want to use the colors in a div, it'll look funky to use |
There are some additional styles defined in Iris, but I wanted to change as little as possible in the CSS, since this applies to many different apps. We should be able to define app-specific classes like: .foo {
@include alert-variant($alert-flash-notice-bg, $alert-flash-notice-border, $alert-flash-notice-color);
} though I suppose I could define a parallel set that are used by the flashhash directly, like changing: .alert-success {
@include alert-variant($alert-flash-notice-bg, $alert-flash-notice-border, $alert-flash-notice-color);
} to .alert-success, .flash.notice {
@include alert-variant($alert-flash-notice-bg, $alert-flash-notice-border, $alert-flash-notice-color);
} That would let us remove those definitions from our CSS in the apps. |
@jcavena OK added definitions for that! |
Ref: https://github.com/radiusnetworks/iris/issues/3167
The colors were originally defined in Iris overrides, but those colors
were only being applied to flash hashes. Error blocks and other bits
here and there would have the original themed alerts come through, and
these colors are more saturated and a bit "harsher".
The original colors have been preserved in case they are used elsewhere,
but the alerts themselves have been re-skinned to use the new color
variables, which have been named in alignment with flashhash keys.
Post Deploy
All apps using this gem will need to be updated.