Fix redirect injection #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljeske
commented
Dec 10, 2016
| @@ -127,7 +127,7 @@ describe('permission', function () { | |||
| // THEN | |||
| expect(redirectStateName).toBePromise(); | |||
| expect(redirectStateName).toBeResolvedWith({state: 'adminRedirect'}); | |||
| expect(adminRedirectTo).toHaveBeenCalledWith('ADMIN', jasmine.any(Object)); | |||
| expect(adminRedirectTo).toHaveBeenCalledWith(PermRoleStore, 'ADMIN'); | |||
There was a problem hiding this comment.
These are used to assert the passed in, arbitrary injection values declared on the above $inject = [] assignment
joeljeske
commented
Dec 12, 2016
| } | ||
|
|
||
| if (angular.isObject(redirection)) { | ||
| } else if (angular.isObject(redirection)) { |
There was a problem hiding this comment.
I had to do this here since isObject([]) === true. It was re-defining the property as this function instead of the array-syntax injected function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently after v5.x, redirectTo custom injection is broken. It was due to overridden $inject property.
Also, I removed the extraneous $inject properties used on the wrapped functions as I saw them as unneeded. I don't have a huge preference though if you really want them