New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong function arguments order #6

Open

Pudge3228 opened this issue Feb 15, 2023 · 0 comments

Pudge3228 commented Feb 15, 2023

refactor arguments order in functions

sdk/src/utils/liquidity.ts

Lines 9 to 15 in b3b5ac5

    
           export function maxLiquidityForAmounts( 
        
             sqrtPriceCurrent: BigNumberish, 
        
             tickLower: number, 
        
             tickUpper: number, 
        
             vQuoteAmount: BigNumberish, 
        
             vTokenAmount: BigNumberish, 
        
             useFullPrecision: boolean

sdk/src/utils/liquidity.ts

Lines 37 to 42 in b3b5ac5

    
           export function amountsForLiquidity( 
        
             tickLower: number, 
        
             sqrtPriceCurrent: BigNumberish, 
        
             tickUpper: number, 
        
             liquidity: BigNumberish, 
        
             roundUp?: boolean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment