forked from nodejs/node
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update timezone to 2022f #4
Closed
github-actions
wants to merge
3
commits into
main
from
test/add-a-test-to-ensure-the-correctness-of-timezone-upgrades
Closed
deps: update timezone to 2022f #4
github-actions
wants to merge
3
commits into
main
from
test/add-a-test-to-ensure-the-correctness-of-timezone-upgrades
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Signed-off-by: Darshan Sen <raisinten@gmail.com>
Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
added a commit
that referenced
this pull request
Nov 3, 2022
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in #4. Signed-off-by: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 10, 2022
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in RaisinTen#4. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #45299 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau
pushed a commit
to richardlau/node-1
that referenced
this pull request
Nov 19, 2022
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in RaisinTen#4. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#45299 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau
pushed a commit
to richardlau/node-1
that referenced
this pull request
Nov 19, 2022
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in RaisinTen#4. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#45299 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 21, 2022
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in RaisinTen#4. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #45299 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 23, 2022
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in RaisinTen#4. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #45299 Backport-PR-URL: #45521 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Fixes: #45276
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 24, 2022
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in RaisinTen#4. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #45299 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 24, 2022
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in RaisinTen#4. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #45299 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in RaisinTen/node#4. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#45299 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in RaisinTen/node#4. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#45299 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Jan 3, 2023
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in RaisinTen#4. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #45299 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated by tools/timezone-update.yml.
Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data
To test, build node off this branch & log the version of tz using