Skip to content

Commit

Permalink
Auto merge of #111717 - Urgau:uplift_fn_null_check, r=oli-obk
Browse files Browse the repository at this point in the history
Uplift `clippy::fn_null_check` lint

This PR aims at uplifting the `clippy::fn_null_check` lint into rustc.

## `incorrect_fn_null_checks`

(warn-by-default)

The `incorrect_fn_null_checks` lint checks for expression that checks if a function pointer is null.

### Example

```rust
let fn_ptr: fn() = /* somehow obtained nullable function pointer */

if (fn_ptr as *const ()).is_null() { /* ... */ }
```

### Explanation

Function pointers are assumed to be non-null, checking for their nullity is incorrect.

-----

Mostly followed the instructions for uplifting a clippy lint described here: rust-lang/rust#99696 (review)

`@rustbot` label: +I-lang-nominated
r? compiler
  • Loading branch information
bors committed Jul 11, 2023
2 parents fc143c5 + de38254 commit 3810294
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 3810294

Please sign in to comment.