Rollup merge of #110563 - bryangarza:refactor-trait-selection-error-r…

…eporting, r=compiler-errors

Break up long function in trait selection error reporting + clean up nearby code

- Move blocks of code into their own functions
- Replace a few function argument types with their type aliases
- Create "AppendConstMessage" enum to replace a nested `Option`.