Skip to content

Commit

Permalink
Merge pull request #5057 from justinas-b/master
Browse files Browse the repository at this point in the history
ISSUE-2760 Resolving compatibility issues with Microsoft Bot Framework emulator
  • Loading branch information
tmbo authored Jan 15, 2020
2 parents 1df2158 + 21e6b21 commit 6b879b6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog/5057.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed compatibility issue with Microsoft Bot Framework Emulator if ``service_url`` lacked a trailing ``/``.
4 changes: 4 additions & 0 deletions rasa/core/channels/botframework.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ def __init__(
service_url: Text,
) -> None:

service_url = (
f"{service_url}/" if not service_url.endswith("/") else service_url
)

self.app_id = app_id
self.app_password = app_password
self.conversation = conversation
Expand Down

0 comments on commit 6b879b6

Please sign in to comment.