Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy assignment #10974

Merged
merged 34 commits into from
Mar 15, 2022
Merged

Fix mypy assignment #10974

merged 34 commits into from
Mar 15, 2022

Conversation

m-vdb
Copy link
Collaborator

@m-vdb m-vdb commented Mar 9, 2022 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

m-vdb added 19 commits March 4, 2022 11:24
@m-vdb
enable mypy "assignment" check
e975eee
@m-vdb
add changelog entry
80425e1
@m-vdb
fix type issues in rasa.cli
078a9e3
@m-vdb
fix type issue in rasa.core.brokers and rasa.core.channels
fbc3a93
@m-vdb
fix some type issues in rasa.core
a658473
@m-vdb
fix rasa.cli type issues with Union[Text, Path]
612d524
@m-vdb
fix remaining issues in rasa.core
1a969ce
@m-vdb
fix type issues in rasa.engine and friends
0c61d0c
@m-vdb
Merge branch 'main' into fix-mypy-assignment
541d764
@m-vdb
fix type issues in rasa.shared.core
38b8ed3
@m-vdb
fix type issues in rasa.utils and rasa.telemetry
c50e750
@m-vdb
fix type issues in rasa.nlu
0ecca6b
@m-vdb
fix remaining issues in rasa.shared
7b418ab
@m-vdb
fix remaining issues in rasa.nlu
4e5e82d
@m-vdb
Merge branch 'main' into fix-mypy-assignment
4d4b8d4
@m-vdb
fix remaining lint errors
ca38dcb
@m-vdb
fix defaultdict typing
f093340
@m-vdb
use TextSlot instead of Slot() in tests
a5869b0
@m-vdb
_get_parameter_information() plays well with type-hinted "cls"
1eb59c1
@m-vdb m-vdb requested review from joejuzl and ka-bu March 11, 2022 13:42
@m-vdb m-vdb marked this pull request as ready for review March 11, 2022 13:42
@m-vdb m-vdb requested a review from a team March 11, 2022 13:42
@m-vdb m-vdb requested a review from a team as a code owner March 11, 2022 13:42
@m-vdb m-vdb requested review from wochinge and removed request for joejuzl March 14, 2022 07:51
wochinge
wochinge reviewed Mar 14, 2022
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR 🚀 So close to have mypy wrapped up 🚀

rasa/cli/interactive.py Outdated Show resolved Hide resolved
rasa/cli/shell.py Show resolved Hide resolved
rasa/cli/test.py Show resolved Hide resolved
rasa/cli/utils.py Show resolved Hide resolved
rasa/cli/utils.py Outdated Show resolved Hide resolved
rasa/model.py Outdated Show resolved Hide resolved
rasa/shared/core/slots.py Show resolved Hide resolved
rasa/shared/importers/importer.py Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
stubs/aio_pika/__init__.pyi Show resolved Hide resolved
@m-vdb m-vdb requested a review from wochinge March 15, 2022 09:10
wochinge
wochinge approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

rasa/cli/interactive.py Outdated Show resolved Hide resolved
rasa/cli/interactive.py Outdated Show resolved Hide resolved
m-vdb and others added 2 commits March 15, 2022 12:06
ka-bu
ka-bu reviewed Mar 15, 2022
View reviewed changes
Copy link
Contributor

@ka-bu ka-bu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - halfway through and only spotted small things (and want DefaultDict annotation back :D)

rasa/core/policies/memoization.py Show resolved Hide resolved
rasa/core/policies/policy.py Show resolved Hide resolved
rasa/core/training/story_conflict.py Outdated Show resolved Hide resolved
@m-vdb
Copy link
Collaborator Author

m-vdb commented Mar 15, 2022

Looks good - halfway through and only spotted small things (and want DefaultDict annotation back :D)

@ka-bu do you want more time for the review then? it doesn't have to get merged today

ka-bu
ka-bu reviewed Mar 15, 2022
View reviewed changes
Copy link
Contributor

@ka-bu ka-bu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing all those fixes you did along the way => 🥳

rasa/shared/core/domain.py Outdated Show resolved Hide resolved
rasa/shared/core/domain.py Outdated Show resolved Hide resolved
rasa/utils/tensorflow/models.py Show resolved Hide resolved
@ka-bu
Copy link
Contributor

ka-bu commented Mar 15, 2022

Looks good - halfway through and only spotted small things (and want DefaultDict annotation back :D)

@ka-bu do you want more time for the review then? it doesn't have to get merged today

done :)

@m-vdb m-vdb enabled auto-merge March 15, 2022 15:17
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://10974--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@m-vdb m-vdb disabled auto-merge March 15, 2022 16:08
@m-vdb m-vdb merged commit a977a8f into main Mar 15, 2022
@m-vdb m-vdb deleted the fix-mypy-assignment branch March 15, 2022 16:08
@m-vdb m-vdb mentioned this pull request Mar 17, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ka-bu ka-bu ka-bu left review comments

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New action creation fails in rasa interactive Enable mypy assignment error code
3 participants
@m-vdb @ka-bu @wochinge