Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symlinks, this should fix #5204 #5292

Merged
merged 6 commits into from
Feb 25, 2020
Merged

Allow symlinks, this should fix #5204 #5292

merged 6 commits into from
Feb 25, 2020

Conversation

govertbuijs
Copy link
Contributor

@govertbuijs govertbuijs commented Feb 21, 2020

Proposed changes:

  • ...

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@claassistantio
Copy link

claassistantio commented Feb 21, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ⭐

Before we can merge this we need to make sure the change is documented. Do you mind creating a changelog entry? You need to create a file in /changelog describing in a sentence what the change does

@govertbuijs
Copy link
Contributor Author

Done

@tmbo
Copy link
Member

tmbo commented Feb 25, 2020

Thanks a lot for that change to make the file detection better 🚀

@tmbo tmbo merged commit d357bfe into RasaHQ:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants