Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepared release of version 1.8.3 #5513

Merged
merged 2 commits into from
Mar 27, 2020
Merged

prepared release of version 1.8.3 #5513

merged 2 commits into from
Mar 27, 2020

Conversation

dakshvar22
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@dakshvar22 dakshvar22 requested a review from Ghostvv March 27, 2020 10:32
erohmensing
erohmensing approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm wondering if we should remove the repeat entries from the 1.9.0 changelog if they're also on this version then?

@dakshvar22 dakshvar22 merged commit ba5e544 into 1.8.x Mar 27, 2020
@dakshvar22 dakshvar22 deleted the prepare-release-1.8.3 branch March 27, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

@Ghostvv Ghostvv Ghostvv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakshvar22 @Ghostvv @erohmensing