validate user input in activation #6172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wochinge
approved these changes
Jul 9, 2020
| @@ -43,6 +44,7 @@ async def is_activated( | |||
|
|
|||
| # default implementation checks if form active | |||
| def _default_activation_events(self) -> List[Event]: | |||
| # TODO if this is in the loop action, probably it should not be `Form` | |||
There was a problem hiding this comment.
You mean we should rename the event?
There was a problem hiding this comment.
yes, and also think whether we want to use the same event name for forms and loops. So we need to think through how they interact with each other. Let's tackle it separately. I added TODO so that we don't forget
Co-authored-by: Tobias Wochinger <t.wochinger@rasa.com>
wochinge
added a commit
that referenced
this pull request
Jul 9, 2020
* have one validate function for the whole form * remove unused function * more tests * remove unnecessary ignores * add clarification comment * validate user input in activation (#6172) * validate user input in activation Co-authored-by: Tobias Wochinger <t.wochinger@rasa.com> * more tests for entity extraction * more `FormAction` tests * add todo Co-authored-by: Vladimir Vlasov <vladimir@rasa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)