Update to PR [#6926] #7064
Merged
Update to PR [#6926] #7064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original issue was [RasaHQ#6496], where the --version command breaks in windows. Eventhough the PR[RasaHQ#6926] solved the problem, it looked a bit complicated of parsing twice. In this fix, I used platform.python_version() to solve the issue. Working both in windows and linux.
|
|
|
Thanks for submitting a pull request 🚀 @dakshvar22 will take a look at it as soon as possible ✨ |
|
Hey @chmodsss, thanks so much for the PR. Would you mind rebasing this to merge it into the 2.0.x branch, so we can release it in a micro? |
erohmensing
requested review from
erohmensing
and removed request for
dakshvar22
|
Sorry, I should have clarified, changing the base branch doesn't do it alone, you have to change the base of where the changes come from. I'd do it on your branch if I could! I'll just merge this PR into master and cherry-pick your fix, no problem :) |
erohmensing
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue was [#6496], where the --version command breaks in windows.
Eventhough the PR[#6926] solved the problem, it looked a bit complicated of parsing twice.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)