Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unit tests] Don't load Poetry cache for Windows #7509

Merged
merged 10 commits into from
Dec 10, 2020
Merged

[Unit tests] Don't load Poetry cache for Windows #7509

merged 10 commits into from
Dec 10, 2020

Conversation

tczekajlo
Copy link
Contributor

@tczekajlo tczekajlo commented Dec 10, 2020 •
edited
Loading

Proposed changes:

  • Use the same key name to restore a cache
  • Don't load Poetry cache for Windows
  • Include poetry version in a cache key

@tczekajlo tczekajlo self-assigned this Dec 10, 2020
@tczekajlo tczekajlo marked this pull request as draft December 10, 2020 09:57
@tczekajlo tczekajlo requested a review from m-vdb December 10, 2020 14:20
@tczekajlo tczekajlo marked this pull request as ready for review December 10, 2020 14:20
@tczekajlo tczekajlo changed the title [Unit tests] Change a cache key [Unit tests] Don't load Poetry cache for Windows Dec 10, 2020
@tczekajlo
Copy link
Contributor Author

@m-vdb Can you 👀 and ✅ ? It's a temporary fix for Windows - #7507

m-vdb
m-vdb approved these changes Dec 10, 2020
View reviewed changes
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥥

.github/workflows/continous-integration.yml Show resolved Hide resolved
@rasabot rasabot merged commit 0be5ffe into master Dec 10, 2020
@rasabot rasabot deleted the fix_windows_test_cache branch December 10, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vdb m-vdb m-vdb approved these changes

Assignees

@tczekajlo tczekajlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tczekajlo @m-vdb @rasabot