Expose default params and create message id counter in createProof if not present #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhchia
deleted the
feat/expose-default-params-and-change-message-id-counter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done?
getDefaultRLNParamsandgetDefaultWithdrawParams: allows devs to download default params before initiating RLN instance. It can save bandwidth and loading time when there are multiple RLN instances instantiated with default params since by default they will download the same files multiple times.createProofwhile a message id counter is not set (possible when restarting an app), set a newMemoryMessageIDCounterand emit a warning that user will risk being slashed if it's still the same epoch and user has sent messages before.