Put resources outside package #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Put default resources to an external storage and access it through URL - Add `RLN.create` which downloads the default resources if devs didn't give resources - Fix tests
|
Merge it for now since we'd need this feature and NodeJS v16 has passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's wrong?
Previously resources were encoded in base64 to make it easier to support both NodeJS and browser, as mentioned in #93. However, it drastically increases the bundle size and it even failed to work in firefox, as reported by the CryptKeeper team.
Fixes #93.
How it is fixed?
Thanks to the examples from Semaphore and zkitter, we can host the resources else where and download them while initiating the RLN instance. Now, they are temporarily hosted on https://rln-resources-temp.s3.us-west-1.amazonaws.com/resources. We can change it to a permanent one later, for example, after the trusted setup is done.