Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

flake: add new build dependencies #75

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Conversation

mardukpill
Copy link
Contributor

@mardukpill mardukpill commented Aug 26, 2024

Summary:

  • Set the formatter for the flake to nixfmt-rfc-style.
  • Fixed [BUG] Failed to build with Nix #74 by adding the required build dependencies.
  • Added a new .desktop entry for the razer-settings GUI.

Copy link
Contributor

@JosuGZ JosuGZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably split the refactor and the actual changes so it is easier to review.

I can see that the only changes are adding glib, pango and gtk3 to line 24, which looks good to me (although I have never used nix).

@mardukpill
Copy link
Contributor Author

Ok. I've updated the pr.

Copy link
Contributor

@JosuGZ JosuGZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you have also added the .desktop entry, the PR looks good to me.

I have two questions:

  • Can't the .desktop file be copied from the original inside the .nix file? Otherwise it will be in two places
  • The ìnstall.sh avoids copying this file if the system doesn't have this kind of entry. Do you think every distro will support this .desktop files?

@mardukpill
Copy link
Contributor Author

I agree that it is a little weird that the .desktop file is basically in two places, but we have to do slightly different things with Nix .desktop file as the path of the binary is generated based off the hash of the derivation.

For your other question, I have only used Nix on NixOS, so I am not quite sure. If Nix was installed on a different distro and used as the package manager to install razer-laptop-control, it will build fine (I think even if .desktop file was unused).

@phush0 phush0 merged commit 2f156a7 into Razer-Linux:main Oct 18, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Failed to build with Nix
3 participants