-
-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably split the refactor and the actual changes so it is easier to review.
I can see that the only changes are adding glib
, pango
and gtk3
to line 24, which looks good to me (although I have never used nix).
4d3cff2
to
cfa5c50
Compare
flake: create .desktop entry for razer-settings
Ok. I've updated the pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you have also added the .desktop entry, the PR looks good to me.
I have two questions:
- Can't the
.desktop
file be copied from the original inside the.nix
file? Otherwise it will be in two places - The
ìnstall.sh
avoids copying this file if the system doesn't have this kind of entry. Do you think every distro will support this.desktop
files?
I agree that it is a little weird that the .desktop file is basically in two places, but we have to do slightly different things with Nix For your other question, I have only used Nix on NixOS, so I am not quite sure. If Nix was installed on a different distro and used as the package manager to install razer-laptop-control, it will build fine (I think even if |
Summary:
nixfmt-rfc-style
..desktop
entry for therazer-settings
GUI.