-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing support for async_std types #26
Conversation
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Can you also write tests? I guess they should be implemented as a separate crate or example or something. I'm not familiar with async at all. |
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
|
||
[target.'cfg(unix)'.dependencies] | ||
libc = "0.2" | ||
|
||
[lib] | ||
doctest = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added to avoid testing the documentation examples.
When testing the async
feature the documentation examples fail, this is why I disabled it.
CI fails. |
Is it really necessary to special case this for the types from Related to that, the use of the feature does seem problematic, e.g.
seems to imply that if any crate in the dependency tree enables the |
Agree. I would prefer the integration of this feature to be more simple. |
Superseded by #31 |
This PR contains the code for supporting
async_std
types inMmapOptions
.The
async_std
support is gated using a feature.If someone wants to use this feature has to enable it in their
Cargo.toml
eg.
I tested it on this crate: https://github.com/atolab/zenoh-cdn/tree/feat/all-async
I had no possibility yet to test it on a Windows machine