1.12.0 on CRAN. Bump to 1.12.1

CRAN_Release.cmd

@@ -601,24 +601,34 @@ Bump version to even release number in 3 places :
   1) DESCRIPTION
   2) NEWS (without 'on CRAN date' text as that's not yet known)
   3) dllVersion() at the end of init.c
-DO NOT push to GitHub. Prevents even a slim possibility of user getting premature version. Even release numbers must have been obtained from CRAN and only CRAN. (Too many support problems in past before this procedure brought in.)
+DO NOT push to GitHub. Prevents even a slim possibility of user getting premature version. Even release numbers must have been obtained from CRAN and only CRAN. There were too many support problems in the past before this procedure was brought in.
 R CMD build .
-R CMD check --as-cran data.table_1.11.8.tar.gz
+R CMD check --as-cran data.table_1.12.0.tar.gz
 Resubmit to winbuilder (R-release, R-devel and R-oldrelease)
 Submit to CRAN. Message template :
------
-543 CRAN + 134 BIOC rev deps checked ok.
-9 CRAN packages will break : easycsv, fst, iml, PhenotypeSimulator, popEpi, sdcMicro, SIRItoGTFS, SpaDES.core, splitstackshape
-The maintainers have been contacted; some may have updated already.
-Thanks and best, Matt
------
-1. Bump version in DESCRIPTION to next odd number
-2. Add new heading in NEWS for the next dev version. Add "(date)" on the released heading if already accepted.
-3. Bump 3 version numbers in Makefile
-4. Bump dllVersion() in init.c
-Push to GitHub so dev can continue. Commit message format "1.11.8 submitted to CRAN. Bump to 1.11.9"
-Bump dev number text in homepage banner
-Cross fingers accepted first time. If not, push changes to devel and backport locally
-Close milestone
+------------------------------------------------------------
+Hello,
+Happy New Year and thanks for everything!
+595 CRAN + 135 BIOC rev deps checked ok
+2 already updated on CRAN in advance and should not break: behavr, maditr
+3 will break: checkmate, rENA and SpaDES.core. Maintainers aware and standing ready.
+3 newly in error/warning status on CRAN in the last day or so for non-data.table reasons: segregation, xlm, prediction
+NoLD 'additional issue' resolved
+Requests from Luke Tierney and Tomas Kalibera included, noted and thanked in NEWS.
+Best, Matt
+------------------------------------------------------------
+DO NOT commit or push to GitHub. Leave 4 files (CRAN_Release.cmd, DESCRIPTION, NEWS and init.c) edited and not committed. Include these in a single and final bump commit below.
+DO NOT even use a PR. Because PRs build binaries and we don't want any binary versions of even release numbers available from anywhere other than CRAN.
+Leave milestone open with a 'final checks' issue open. Keep updating status there.
 ** If on EC2, shutdown instance. Otherwise get charged for potentially many days/weeks idle time with no alerts **
+Sleep.
+If any issues arise, backport locally. Resubmit the same even version to CRAN.
+When on CRAN :
+1. Close milestone
+2. Check that 'git status' shows 4 files in modified and uncommitted state: DESCRIPTION, NEWS.md, init.c and this CRAN_Release.cmd
+2. Bump version in DESCRIPTION to next odd number. Note that DESCRIPTION was in edited and uncommitted state so even number never appears in git.
+3. Add new heading in NEWS for the next dev version. Add "(date)" on the released heading.
+4. Bump 3 version numbers in Makefile
+5. Bump dllVersion() in init.c
+Push to master with this consistent commit message: "1.12.0 on CRAN. Bump to 1.12.1"
 

DESCRIPTION

@@ -1,5 +1,5 @@
 Package: data.table
-Version: 1.11.9
+Version: 1.12.1
 Title: Extension of `data.frame`
 Authors@R: c(
   person("Matt","Dowle",      role=c("aut","cre"), email="mattjdowle@gmail.com"),

Makefile

@@ -18,21 +18,21 @@ some:
 
 .PHONY: clean
 clean:
-	rm -f data.table_1.11.9.tar.gz
+	rm -f data.table_1.12.1.tar.gz
 
 .PHONY: build
 build:
 	$(R) CMD build . --no-build-vignettes
 
 .PHONY: install
 install:
-	$(R) CMD INSTALL data.table_1.11.9.tar.gz
+	$(R) CMD INSTALL data.table_1.12.1.tar.gz
 
 .PHONY: test
 test:
 	$(R) -e 'require(data.table); test.data.table()'
 
 .PHONY: check
 check:
-	$(R) CMD check data.table_1.11.9.tar.gz --as-cran --ignore-vignettes --no-stop-on-test-error
+	$(R) CMD check data.table_1.12.1.tar.gz --as-cran --ignore-vignettes --no-stop-on-test-error
 

NEWS.md

@@ -1,6 +1,15 @@
 **If you are viewing this file on CRAN, please check [latest news on GitHub](https://github.com/Rdatatable/data.table/blob/master/NEWS.md) where the formatting is also better.**
 
-### Changes in v1.11.9 (to be v1.12.0)
+### Changes in v1.12.1 (in development)
+
+#### NEW FEATURES
+
+#### BUG FIXES
+
+#### NOTES
+
+
+### Changes in v1.12.0  (13 Jan 2019)
 
 #### NEW FEATURES
 

src/init.c

@@ -326,6 +326,6 @@ SEXP hasOpenMP() {
 
 SEXP dllVersion() {
   // .onLoad calls this and checks the same as packageVersion() to ensure no R/C version mismatch, #3056
-  return(ScalarString(mkChar("1.11.9")));
+  return(ScalarString(mkChar("1.12.1")));
 }