-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear timeout refs correctly #1205
Conversation
WalkthroughThe update replaces Changes
Assessment against linked issues
Poem
Tip AI model upgrade
|
Beta version released with the last commit 🚀
or
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- src/components/Tooltip/Tooltip.tsx (11 hunks)
- src/test/utils.spec.js (2 hunks)
- src/utils/clear-timeout-ref.ts (1 hunks)
- src/utils/index.ts (2 hunks)
Additional comments not posted (15)
src/utils/clear-timeout-ref.ts (1)
1-7
: LGTM!The
clearTimeoutRef
function is well-implemented and follows best practices.src/utils/index.ts (2)
9-9
: LGTM!The import statement for
clearTimeoutRef
is correct and follows the existing pattern.
20-20
: LGTM!The export statement for
clearTimeoutRef
is correct and follows the existing pattern.src/test/utils.spec.js (1)
260-274
: LGTM!The test case for
clearTimeoutRef
is well-implemented and verifies the functionality correctly.src/components/Tooltip/Tooltip.tsx (11)
11-11
: LGTM!The import statement for
clearTimeoutRef
is correct and follows the existing pattern.
227-227
: LGTM!The replacement of
clearTimeout
withclearTimeoutRef
formissedTransitionTimerRef
is correct and ensures the timeout reference is cleared properly.
259-259
: LGTM!The replacement of
clearTimeout
withclearTimeoutRef
fortooltipShowDelayTimerRef
is correct and ensures the timeout reference is cleared properly.
273-273
: LGTM!The replacement of
clearTimeout
withclearTimeoutRef
fortooltipHideDelayTimerRef
is correct and ensures the timeout reference is cleared properly.
305-305
: LGTM!The replacement of
clearTimeout
withclearTimeoutRef
fortooltipHideDelayTimerRef
is correct and ensures the timeout reference is cleared properly.
318-318
: LGTM!The replacement of
clearTimeout
withclearTimeoutRef
fortooltipShowDelayTimerRef
is correct and ensures the timeout reference is cleared properly.
380-380
: LGTM!The replacement of
clearTimeout
withclearTimeoutRef
fortooltipShowDelayTimerRef
is correct and ensures the timeout reference is cleared properly.
689-689
: LGTM!The replacement of
clearTimeout
withclearTimeoutRef
fortooltipShowDelayTimerRef
is correct and ensures the timeout reference is cleared properly.
690-690
: LGTM!The replacement of
clearTimeout
withclearTimeoutRef
fortooltipHideDelayTimerRef
is correct and ensures the timeout reference is cleared properly.
778-778
: LGTM!The replacement of
clearTimeout
withclearTimeoutRef
fortooltipShowDelayTimerRef
is correct and ensures the timeout reference is cleared properly.
779-779
: LGTM!The replacement of
clearTimeout
withclearTimeoutRef
fortooltipHideDelayTimerRef
is correct and ensures the timeout reference is cleared properly.
## [1.0.2](https://github.com/equinor/webviz-subsurface-components/compare/wsc-common@1.0.1...wsc-common@1.0.2) (2024-10-08) ### Bug Fixes * bump react-tooltip from 5.27.0 to 5.28.0 in /typescript ([#2300](#2300)) ([e355c99](e355c99)), closes [#1209](#1209) [ReactTooltip/react-tooltip#1213](ReactTooltip/react-tooltip#1213) [ReactTooltip/react-tooltip#1211](ReactTooltip/react-tooltip#1211) [ReactTooltip/react-tooltip#1213](ReactTooltip/react-tooltip#1213) [ReactTooltip/react-tooltip#1211](ReactTooltip/react-tooltip#1211) [ReactTooltip/react-tooltip#1203](ReactTooltip/react-tooltip#1203) [ReactTooltip/react-tooltip#1205](ReactTooltip/react-tooltip#1205) [#1209](#1209) [#1213](#1213)
## [1.5.6](https://github.com/equinor/webviz-subsurface-components/compare/well-completions-plot@1.5.5...well-completions-plot@1.5.6) (2024-10-08) ### Bug Fixes * bump react-tooltip from 5.27.0 to 5.28.0 in /typescript ([#2300](#2300)) ([e355c99](e355c99)), closes [#1209](#1209) [ReactTooltip/react-tooltip#1213](ReactTooltip/react-tooltip#1213) [ReactTooltip/react-tooltip#1211](ReactTooltip/react-tooltip#1211) [ReactTooltip/react-tooltip#1213](ReactTooltip/react-tooltip#1213) [ReactTooltip/react-tooltip#1211](ReactTooltip/react-tooltip#1211) [ReactTooltip/react-tooltip#1203](ReactTooltip/react-tooltip#1203) [ReactTooltip/react-tooltip#1205](ReactTooltip/react-tooltip#1205) [#1209](#1209) [#1213](#1213)
## [1.0.3](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@1.0.2...subsurface-viewer@1.0.3) (2024-10-08) ### Bug Fixes * bump react-tooltip from 5.27.0 to 5.28.0 in /typescript ([#2300](#2300)) ([e355c99](e355c99)), closes [#1209](#1209) [ReactTooltip/react-tooltip#1213](ReactTooltip/react-tooltip#1213) [ReactTooltip/react-tooltip#1211](ReactTooltip/react-tooltip#1211) [ReactTooltip/react-tooltip#1213](ReactTooltip/react-tooltip#1213) [ReactTooltip/react-tooltip#1211](ReactTooltip/react-tooltip#1211) [ReactTooltip/react-tooltip#1203](ReactTooltip/react-tooltip#1203) [ReactTooltip/react-tooltip#1205](ReactTooltip/react-tooltip#1205) [#1209](#1209) [#1213](#1213)
## [1.3.11](https://github.com/equinor/webviz-subsurface-components/compare/group-tree-plot@1.3.10...group-tree-plot@1.3.11) (2024-10-08) ### Bug Fixes * bump react-tooltip from 5.27.0 to 5.28.0 in /typescript ([#2300](#2300)) ([e355c99](e355c99)), closes [#1209](#1209) [ReactTooltip/react-tooltip#1213](ReactTooltip/react-tooltip#1213) [ReactTooltip/react-tooltip#1211](ReactTooltip/react-tooltip#1211) [ReactTooltip/react-tooltip#1213](ReactTooltip/react-tooltip#1213) [ReactTooltip/react-tooltip#1211](ReactTooltip/react-tooltip#1211) [ReactTooltip/react-tooltip#1203](ReactTooltip/react-tooltip#1203) [ReactTooltip/react-tooltip#1205](ReactTooltip/react-tooltip#1205) [#1209](#1209) [#1213](#1213)
## [2.1.1](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@2.1.0...well-log-viewer@2.1.1) (2024-10-08) ### Bug Fixes * bump react-tooltip from 5.27.0 to 5.28.0 in /typescript ([#2300](#2300)) ([e355c99](e355c99)), closes [#1209](#1209) [ReactTooltip/react-tooltip#1213](ReactTooltip/react-tooltip#1213) [ReactTooltip/react-tooltip#1211](ReactTooltip/react-tooltip#1211) [ReactTooltip/react-tooltip#1213](ReactTooltip/react-tooltip#1213) [ReactTooltip/react-tooltip#1211](ReactTooltip/react-tooltip#1211) [ReactTooltip/react-tooltip#1203](ReactTooltip/react-tooltip#1203) [ReactTooltip/react-tooltip#1205](ReactTooltip/react-tooltip#1205) [#1209](#1209) [#1213](#1213)
Closes #1182
Closes #1204.
See comment here for demo of issue.
See same demo here, fixed with beta release.
Keep in mind this change should not revert fix from #1168 (related to issue #1119, also see sample code).
Summary by CodeRabbit
Bug Fixes
Tests