Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add styles for shadow dom #636

Merged
merged 1 commit into from
Nov 22, 2020
Merged

fix: add styles for shadow dom #636

merged 1 commit into from
Nov 22, 2020

Conversation

sumthief
Copy link
Contributor

@sumthief sumthief commented Oct 2, 2020

fix #597

@sumthief
Copy link
Contributor Author

Hey @roggervalf @aronhelser
Can you review this one please?

@aronhelser
Copy link
Collaborator

Looks good! Can you change your commit message so semantic-release will pick up the change? start like this:

fix(styles): ....

@sumthief
Copy link
Contributor Author

Sorry for delay

Done 🙂

roggervalf
roggervalf approved these changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@roggervalf roggervalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay, thank you @sumthief

@roggervalf roggervalf merged commit 00d1539 into ReactTooltip:master Nov 22, 2020
@sumthief sumthief mentioned this pull request Dec 2, 2020
Closed
@gabrieljablonski gabrieljablonski mentioned this pull request May 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roggervalf roggervalf roggervalf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base stylesheet and the Shadow DOM
3 participants
@sumthief @aronhelser @roggervalf