-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub actions failing #135
Conversation
- xCode 14.3.1 - xCode 15.2 https://xcodereleases.com/
I observed this: there is no longer an active maintainer to merge stuff |
@hannesa2 that's starting to change |
Maybe. I wrote/offered @doranteseduardo via email and Discord about maintenance. But I got no response at all |
Hi @hannesa2, I'm working with @cjmcassar to create a roadmap and start fixing issues and creating a new vision for the project. I'd love to meet with you and talk about maintenance! Shoot me a message on discord at .bcolley or email me at robertcolley04@gmail.com! |
- macos-latest --> macos-12 - Add xcpretty
There's a bigger issue here, which is that we depend on GVRAudioSdk which has been deprecated. I checked following these instructions and it turns out that GVRAudioSDK includes bitcode, which is not allowed on xCode 14. I'm pretty sure this is why the linking is failing on xCode 14 and not the xCode 13 GitHub action. I would push for GVRAudioSDK being replaced with a different library. I looked at the Google Cardboard SDK, but I couldn't find any reference to spacial audio. We only used GVRAudioSDK for spacial audio in a handful of files. I also get the sense that GVR should be deprecated and removed from Viro and we should look for alternatives like Cardboard or something else. Both iOS and Android have spatial audio SDKs that can be a replacement for GVRAudioSDK. |
No description provided.