Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #206

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,18 @@ changelog:
- title: Exciting New Features 🎉
labels:
- enhancement
- title: Dependencies
labels:
- dependencies
- title: Espresso test
labels:
- Espresso
- title: Bug fix
labels:
- bugfix
- title: Pipeline
labels:
- pipeline
- title: Other Changes
labels:
- "*"
20 changes: 0 additions & 20 deletions .github/workflows/gradle-wrapper-validation.yml

This file was deleted.

14 changes: 12 additions & 2 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- main
- develop
pull_request:

jobs:
Expand All @@ -20,6 +21,12 @@ jobs:
- name: assemble ViroCore
run: |
./gradlew :viroreact:assembleDebug
./gradlew :code-samples:ARPlacingObjects:assembleDebug
./gradlew :code-samples:ARRetail:assembleDebug
./gradlew :code-samples:ARTesla:assembleDebug
./gradlew :code-samples:ARHelloWorldAndroid:assembleDebug
./gradlew :code-samples:ARBlackPanther:assembleDebug
./gradlew :mainSample:assembleDebug
working-directory: ./android
- name: Upload result ViroCore
uses: actions/upload-artifact@v4.4.0
Expand All @@ -46,6 +53,7 @@ jobs:
with:
distribution: "adopt"
java-version: 17
- uses: gradle/wrapper-validation-action@v3
- name: Code checks
run: ./gradlew :viroreact:check
- name: Archive Lint report
Expand All @@ -62,9 +70,11 @@ jobs:
strategy:
fail-fast: false
matrix:
xcode: ["14.2.0", "13.4.1"]
macOS: ["macos-12"]
macOS: [ "macos-13" ]
xcode: [ "15.2.0" ]
steps:
- name: Investigate available XCode versions
run: ls -n /Applications/ | grep Xcode*
- uses: actions/checkout@v4.2.0
- name: Install gpg
run: brew install gnupg
Expand Down
52 changes: 0 additions & 52 deletions Jenkinsfile

This file was deleted.

4 changes: 2 additions & 2 deletions android/code-samples/ARBlackPanther/build.gradle
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
apply plugin: 'com.android.library'

android {
compileSdkVersion 33
compileSdkVersion 34
namespace "com.example.virosample.blackPanther"

defaultConfig {
minSdkVersion 24
targetSdkVersion 33
targetSdkVersion 34
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
ndkVersion = "25.2.9519653"
ndk {
Expand Down
4 changes: 2 additions & 2 deletions android/code-samples/ARHelloWorldAndroid/build.gradle
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
apply plugin: 'com.android.library'

android {
compileSdkVersion 33
compileSdkVersion 34
namespace "com.example.virosample.hello"

defaultConfig {
minSdkVersion 24
targetSdkVersion 33
targetSdkVersion 34
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
ndkVersion = "25.2.9519653"
ndk {
Expand Down
9 changes: 6 additions & 3 deletions android/code-samples/ARPlacingObjects/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,22 @@ apply plugin: 'com.android.library'
apply plugin: 'kotlin-android'

android {
compileSdkVersion 33
compileSdkVersion 34
namespace "com.example.virosample.placingObjects"

defaultConfig {
minSdkVersion 24
targetSdkVersion 33
targetSdkVersion 34
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
ndkVersion = "25.2.9519653"
ndk {
abiFilters "arm64-v8a", "armeabi-v7a", "x86", "armeabi", "mips"
}
}

compileOptions {
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}
lintOptions {
disable 'UsingOnClickInXml'
}
Expand Down
4 changes: 2 additions & 2 deletions android/code-samples/ARRetail/build.gradle
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
apply plugin: 'com.android.library'

android {
compileSdkVersion 33
compileSdkVersion 34
namespace "com.example.virosample.retail"

defaultConfig {
minSdkVersion 24
targetSdkVersion 33
targetSdkVersion 34
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
ndkVersion = "25.2.9519653"
ndk {
Expand Down
4 changes: 2 additions & 2 deletions android/code-samples/ARTesla/build.gradle
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
apply plugin: 'com.android.library'

android {
compileSdkVersion 33
compileSdkVersion 34
namespace "com.example.virosample.tesla"

defaultConfig {
minSdkVersion 24
targetSdkVersion 33
targetSdkVersion 34
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
ndkVersion = "25.2.9519653"
ndk {
Expand Down
Binary file modified android/gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
4 changes: 3 additions & 1 deletion android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading
Loading